(11) RFR (S) JDK-8196884: VS2017 Multiple Type Cast Conversion Compilation Errors

[Lois Foltan]

Thanks Coleen!
Lois

On 2/16/2018 4:03 PM, coleen.phillimore at oracle.com wrote:

>
> These changes look good.  Agree that hopefully these can be replaced 
> with some BAD_PTR in the future.
> Coleen
>
> On 2/16/18 3:37 PM, Lois Foltan wrote:
>> Please review this fix for multiple type cast conversion compilation 
>> errors.  This fix includes a change to correctly type the symbolic 
>> constants badAddressVal and badOopVal in globalDefinitions.hpp and 
>> adjust numerous type cast conversions for the constant 0xdeadbeef.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8196884/webrev/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8196884
>>
>> Suggestions in the bug to remove the questionable remaining use of 
>> badOopVal as well as introduce a BAD_PTR macro definition for 
>> 0xdeadbeef have been filed as RFEs:
>> - Removal of BadOopVal https://bugs.openjdk.java.net/browse/JDK-8198308
>> - Introduce BAD_PTR https://bugs.openjdk.java.net/browse/JDK-8198309
>>
>> Testing in progress (hs-tier1-3, jdk-tier1-3)
>>
>> Thanks,
>> Lois
>