(11) RFR (S) JDK-8196884: VS2017 Multiple Type Cast Conversion Compilation Errors

Lois Foltan lois.foltan at oracle.com
Mon Feb 19 13:46:32 UTC 2018


Thanks Kim for the review!
Lois

On 2/17/2018 12:29 PM, Kim Barrett wrote:

>> On Feb 16, 2018, at 3:37 PM, Lois Foltan <lois.foltan at oracle.com> wrote:
>>
>> Please review this fix for multiple type cast conversion compilation errors.  This fix includes a change to correctly type the symbolic constants badAddressVal and badOopVal in globalDefinitions.hpp and adjust numerous type cast conversions for the constant 0xdeadbeef.
>>
>> open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8196884/webrev/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8196884
>>
>> Suggestions in the bug to remove the questionable remaining use of badOopVal as well as introduce a BAD_PTR macro definition for 0xdeadbeef have been filed as RFEs:
>> - Removal of BadOopVal https://bugs.openjdk.java.net/browse/JDK-8198308
>> - Introduce BAD_PTR https://bugs.openjdk.java.net/browse/JDK-8198309
>>
>> Testing in progress (hs-tier1-3, jdk-tier1-3)
>>
>> Thanks,
>> Lois
> Looks good, given JDK-8196309 as a trailing cleanup.
>



More information about the hotspot-dev mailing list