RFR JDK-8194084: Obsolete FastTLABRefill and remove the related code
JC Beyler
jcbeyler at google.com
Tue Feb 20 17:10:29 UTC 2018
Apart from better code for x86 as well, no not really. Any other opinions?
Slightly optimize that piece of code or leave as is?
On Tue, Feb 20, 2018 at 8:56 AM, Andrew Haley <aph at redhat.com> wrote:
> On 20/02/18 16:22, JC Beyler wrote:
> > I added a no_pop slowpath, fixed the str to stp for aarch64, and then did
> > the same no_pop slowpath for x86. I can also remove the no_pop label and
> > just fix the aarch64 code by moving the str/ldr to stp/ldp and moving the
> > stp before the jump to the slowpath.
> >
> > Let me know and thanks!
>
> I'd do the latter. There's no real justification for changing the x86
> code, is there?
>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
>
More information about the hotspot-dev
mailing list