RFR: 8198474: Move JNIHandles::resolve into jniHandles.inline.hpp

[Thomas Schatzl]

Hi Kim,

  seem good, two minor comments:

  - in jvmciCodeInstaller.hpp and jvmciJavaClasses.hpp, can the "FIXME"
comment elaborate a bit more what's broken, and file a CR, maybe even
detailing how this could be fixed.
If it is not current any more, please remove the comments.

I just really really do not like "FIXME" comments, nobody is going to
remember next time what the issue was, whether it has been fixed, etc.

  - copyright update in jvmtiEnvBase.hpp missing

Thanks,
  Thomas

On Tue, 2018-02-20 at 22:02 -0500, Kim Barrett wrote:
> Please review this change to split jniHandles.hpp, moving the inline
> definition of JNIHandles::resolve and related functions to the new
> jniHandles.inline.hpp.  This is being done in preparation for
> JDK-8195972 "Refactor oops in JNI to use the Access API".  This is
> needed so we can include access.inline.hpp as part of that change,
> making the implementation of Access available for reference by
> JNIHandles::resolve &etc.
> 
> This was accomplished largly by a simple copy of the code, and
> updating the #includes of lots of files.  However,
> resolve_external_guard was changed to no longer be inline.  It
> doesn't
> seem to be performance critical, and this change reduced the fanout
> on
> #include updates.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8198474
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8198474/open.00/
> [Note to Oracle reviewers: There is a closed part to this change
> too.]
> 
> Testing:
> hs-tier1 in isolation
> {hs,jdk}-tier{1,2,3} JDK-8195972 as part of changes for JDK-8195972
> 
>