RFR: 8198474: Move JNIHandles::resolve into jniHandles.inline.hpp

Thomas Schatzl thomas.schatzl at oracle.com
Thu Feb 22 07:16:31 UTC 2018


Hi,

On Wed, 2018-02-21 at 11:56 -0500, Kim Barrett wrote:
> > On Feb 21, 2018, at 7:44 AM, Thomas Schatzl <thomas.schatzl at oracle.
> > com> wrote:
> > 
> > Hi Kim,
> > 
> >  seem good, two minor comments:
> > 
> >  - in jvmciCodeInstaller.hpp and jvmciJavaClasses.hpp, can the
> > "FIXME" comment elaborate a bit more what's broken, and file a CR,
> > maybe even detailing how this could be fixed.
> > If it is not current any more, please remove the comments.
> > 
> > I just really really do not like "FIXME" comments, nobody is going
> > to remember next time what the issue was, whether it has been
> > fixed, etc.
> 
> I completely forgot about these FIXMEs, and shouldn’t have put out
> the RFR
> with them still present.  My apologies for this.
> 

  okay, looks good without the fixme's and the copyright update. No
need to see another webrev for these trivial changes.

Thanks,
  Thomas


More information about the hotspot-dev mailing list