RFR(M): 8194814 [ppc, s390] A row of minor fixes and cleanups
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Tue Jan 9 12:47:34 UTC 2018
Hi Martin,
I implemented your requests:
http://cr.openjdk.java.net/~goetz/wr18/8194814-ppcCleanup/webrev.02/
Thanks for your review!
Best regards,
Goetz
> -----Original Message-----
> From: Doerr, Martin
> Sent: Dienstag, 9. Januar 2018 12:51
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-
> dev at openjdk.java.net
> Subject: RE: RFR(M): 8194814 [ppc, s390] A row of minor fixes and cleanups
>
> Hi Götz,
>
> looks basically good.
>
> I only have minor change requests.
>
> icache_ppc.cpp doesn't need anything from asm/... so I'd prefer to remove
> the include.
>
> vtable_stubs_ppc_64.cpp changes may interfere with changes in other
> repositories. I suggest to skip this file for now to avoid merge conflicts.
>
> Best regards,
> Martin
>
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> Behalf Of Lindenmaier, Goetz
> Sent: Dienstag, 9. Januar 2018 09:11
> To: hotspot-dev at openjdk.java.net
> Subject: RFR(M): 8194814 [ppc, s390] A row of minor fixes and cleanups
>
> Hi,
>
> could I please get a review for this collection of minor fixes
> and cleanups in the ppc and s390 platform files?
> http://cr.openjdk.java.net/~goetz/wr18/8194814-ppcCleanup/webrev.01/
>
> Thanks,
> Goetz.
More information about the hotspot-dev
mailing list