RFR(M) : 8186635: ClassFileInstaller should be run as a driver

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Thu Jan 18 18:07:27 UTC 2018


Change looks good to me,

Misha

On 1/17/18, 4:27 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8186635/webrev.00/index.html
>> 194 lines changed: 0 ins; 0 del;
> Hi all,
>
> could you please review the patch which replaces all '@run main ClassFileInstaller' w/ '@run driver ClassFileInstaller' in hotspot tests?
>
> ClassFileInstaller is a widely used aux class which doesn't have to be run in JVM under test and/or w/ external flags. Running ClassFileInstaller as a driver can not only improve test stability, but also speed up test execution as jtreg will be able to reuse agent JVMs and these JVMs won't have any stress flags.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8186635/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8186635
> testing: all changed tests
>
> Thanks,
> -- Igor
>


More information about the hotspot-dev mailing list