RFR(S): 8170941: Executing gtest with invalid -Xlog argument crashes gtestLauncher

Thomas Stüfe thomas.stuefe at gmail.com
Mon Jan 22 11:57:57 UTC 2018


Thanks Marcus for fixing this. Looks fine.

On Mon, Jan 22, 2018 at 9:25 AM, Marcus Larsson <marcus.larsson at oracle.com>
wrote:

> Thanks Robbin!
>
>
>
> On 2018-01-22 09:14, Robbin Ehn wrote:
>
>> Hi Marcus, looks good!
>>
>> /Robbin
>>
>> On 01/18/2018 04:20 PM, Marcus Larsson wrote:
>>
>>> Hi,
>>>
>>> Please review the following small patch to prevent the gtest runner from
>>> crashing if invalid VM arguments are passed in.
>>> The launcher will now exit with an error message rather than hit some
>>> assert in the half initialized VM.
>>>
>>> Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8170941
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~mlarsson/8170941/webrev.00
>>>
>>> Thanks,
>>> Marcus
>>>
>>
>


More information about the hotspot-dev mailing list