RFR : 8196062 : Enable docker container related tests for linux ppc64le

[Dmitry Samersoff]

Matthias,

osContainer_linux.cpp:

Could you cleanup the code a bit?

It might be better to log && bailout if

c == NULL,
c->subsystem_path() == NULL,
strlen(c->subsystem_path()) + strlen(filename) > MAXPATHLEN

right after start of function (at l. 124)

it reduces number of branches below and makes code much more readable,
also we don't need str*n*cat at l. 133 because we checked for overflow
before.

-Dmitry


On 01/24/2018 05:24 PM, Baesken, Matthias wrote:
> Hello,  could you please review the following change :  8196062 :  Enable docker container related tests for linux ppc64le  .
> 
> It  adds  docker container testing   for linux ppc64 le  (little endian) .
> 
> A number of things had to be done :
> 
>   *   Add a  separate  docker file      test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le      for linux ppc64 le     which uses   Ubuntu ( the  Oracle Linux 7.2  used  for x86_64  seems not to be available for ppc64le )
>   *   Fix  parsing    /proc/self/mountinfo    and   /proc/self/cgroup  in    src/hotspot/os/linux/osContainer_linux.cpp    , it could  not  handle  the format seen  on SUSE LINUX 12.1 ppc64le (Host)  and  Ubuntu (Docker container)
>   *   Add a bit  more logging
> 
> 
> Webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8196062/
> 
> 
> Bug :
> 
> https://bugs.openjdk.java.net/browse/JDK-8196062
> 
> 
> After these adjustments I could run the    runtime/containers/docker    -  jtreg tests successfully .
> 
> 
> Best regards, Matthias
> 
>