RFR: 8194898: Move OopStorage inline definitions to an .inline.hpp

[harold seigel]

Hi Kim,

These changes looks good.

Thanks, Harold


On 1/24/2018 2:54 PM, coleen.phillimore at oracle.com wrote:
>
> This looks very nice!
>
> There's a minor inconsistency with the hotspot code, most nonstatic 
> data members are declared at the beginning of the class:
>
> 160   OopStorage* _storage;
> 161   void* volatile _next_block;
> 162   bool _concurrent;
>
> These should move up to line 144.   Some people like the member names 
> lined up too. :)
>
> I don't need to see this trivial change.
>
> Thanks,
> Coleen
>
> On 1/19/18 2:59 PM, Kim Barrett wrote:
>> Please review this code reorg for the recently added OopStorage.
>> During the review of OopStorage (JDK-8194312) it was requested that
>> the inline member function definitions and inner class definitions be
>> moved to .inline.hpp file(s).
>>
>> The changes are:
>>
>> (1) ParState and BasicParState are moved to the new file
>> oopStorageParState.inline.hpp. Also moved AlwaysTrueFn into 
>> BasicParState,
>> which is the only user.
>>
>> (2) Moved the inline member function to the new file 
>> oopStorage.inline.hpp,
>> along with most of the inner class definitions.  The complete 
>> definitions of
>> BlockEntry and BlockList remain within the OopStorage definition, as 
>> they are
>> needed for member types.
>>
>> (3) Added inline qualifiers to public OopStorage function declarations
>> when the function definition is in an inline header.  This may produce
>> better error messages by some compilers when the inline header is
>> needed but not included.
>>
>> Note: This change will likely have a simple merge conflict (unrelated
>> nearby changes to oopStorage.hpp) with the fix for JDK-8195691. Since
>> I'm sponsoring the latter, I'll deal with that when the time comes,
>> for whichever order these changes end up being pushed.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8194898
>>
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8194898/open.00/
>>
>> Testing:
>> hs-tier1,2,3
>>
>