RFR: 8194898: Move OopStorage inline definitions to an .inline.hpp

Kim Barrett kim.barrett at oracle.com
Mon Jan 29 20:50:17 UTC 2018


> On Jan 24, 2018, at 2:54 PM, coleen.phillimore at oracle.com wrote:
> 
> 
> This looks very nice!
> 
> There's a minor inconsistency with the hotspot code, most nonstatic data members are declared at the beginning of the class:
> 
> 160   OopStorage* _storage;
> 161   void* volatile _next_block;
> 162   bool _concurrent;
> 
> These should move up to line 144.   Some people like the member names lined up too. :)

Thanks.  I’ll move these declarations.



More information about the hotspot-dev mailing list