RFR (S) 8196199: Remove miscellaneous oop comparison operators

Kim Barrett kim.barrett at oracle.com
Wed Jan 31 21:01:02 UTC 2018


> On Jan 31, 2018, at 2:30 PM, harold seigel <harold.seigel at oracle.com> wrote:
> 
> Hi Coleen,
> 
> This change looks good.
> 
> In jniCheck.cpp, you could use the is_null(oop obj) function defined in oop.hpp instead of 'oop == NULL’.

I like this suggestion, and wish I’d thought of it while writing the initial code.  I think it should be applied to all of the former uses of operator!.  Coleen?

> Harold
> 
> 
> On 1/30/2018 5:58 PM, coleen.phillimore at oracle.com wrote:
>> CheckUnhandledOops had defined some oop comparison operators that will have to be rewritten for new GCs.   Kim Barrett did most of this change. See CR for more info.
>> 
>> Tested with JPRT (using currently supported GCs) tier1 and locally.
>> 
>> open webrev at http://cr.openjdk.java.net/~coleenp/8196199.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8196199
>> 
>> Thanks,
>> Coleen




More information about the hotspot-dev mailing list