RFR(S/M) : 8202561 : clean up TEST.groups file

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jul 3 18:00:27 UTC 2018


Ioi, Vladimir,

thank you for review, I'll make TEST.quick-groups a "new" file before pushing.

-- Igor

> On Jul 3, 2018, at 12:12 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
> 
> Changes look good. I agree with Vladimir that creating a new TEST.quick-groups file is better.
> 
> Thanks
> 
> - Ioi
> 
> 
> On 7/2/18 4:09 PM, Vladimir Kozlov wrote:
>> Thank you for doing this. Looks fine. One question is why you cloned TEST.groups instead of creating new file? Diffs look confusing.
>> 
>> Vladimir
>> 
>> On 6/28/18 11:09 AM, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8202561/webrev.00/index.html
>>>> 2262 lines changed: 2 ins; 2258 del; 2 mod
>>> 
>>> Hi all,
>>> 
>>> could you please review the clean up for hotspot TEST.groups file?
>>> 
>>> the patch moves all vmTestbase_*_quick groups to a separate file TEST.quick-groups.
>>> 
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8202561/webrev.00/index.html
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8202561
>>> 
>>> Thanks,
>>> -- Igor
>>> 
> 



More information about the hotspot-dev mailing list