[8u-backport] RFR: JDK-8081323: ConstantPool::_resolved_references is missing in heap dump

Fairoz Matte fairoz.matte at oracle.com
Wed Jul 4 04:26:32 UTC 2018


Thank you Coleen and David for the reviews.

Thanks,
Fairoz

> -----Original Message-----
> From: Coleen Phillimore
> Sent: Tuesday, July 03, 2018 8:20 PM
> To: hotspot-dev at openjdk.java.net
> Subject: Re: [8u-backport] RFR: JDK-8081323:
> ConstantPool::_resolved_references is missing in heap dump
> 
> 
> Hi Fairoz,  This change looks good and applicable to jdk8u.  The name of
> init_lock will come out as "init_lock" rather than "<init_lock>" in the original
> but I think this is ok.  Better than having two different
> vmSymbols::init_lock_name() functions.
> 
> Thanks,
> Coleen
> 
> On 7/3/18 2:15 AM, Fairoz Matte wrote:
> > Hi,
> >
> > Kindly review the backport of "JDK-8081323:
> > ConstantPool::_resolved_references is missing in heap dump" to 8u
> >
> > I have manually verified the issue with Yourkit, kindly check the
> > images attached to backport bug
> > (https://bugs.openjdk.java.net/browse/JDK-8198556)
> > Also ran hotspot tests.
> >
> > Webrev - http://cr.openjdk.java.net/~fmatte/8081323/webrev.00/
> >
> > JDK 10 bug - https://bugs.openjdk.java.net/browse/JDK-8081323
> >
> > JDK 10 changeset -
> > http://hg.openjdk.java.net/jdk10/hs/rev/d8e417df3468
> >
> > Review thread -
> > http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-
> September/0282
> > 15.html
> >
> > Thanks,
> > Fairoz
> 


More information about the hotspot-dev mailing list