RFR : 8206255 : fix compiler/intrinsics/sha/cli/TestUseSHAOptionOnSupportedCPU.java jtreg test on linux s390x

[Vladimir Kozlov]

Looks good to me too.

Yes, you can still push into jdk11 any p1-3 bugs (not p4-5). And you 
don't need to push it into 12 (jdk/jdk) because it will be pooled from 
jdk11 automatically.

Thanks,
Vladimir

On 7/4/18 4:19 AM, Baesken, Matthias wrote:
> Thanks Thomas ! Can I have a second review please ?
> 
> Btw can I  push this to jdk11  ?
> 
> Best regards, Matthias
> 
>> -----Original Message-----
>> From: Thomas Stüfe [mailto:thomas.stuefe at gmail.com]
>> Sent: Mittwoch, 4. Juli 2018 12:51
>> To: Baesken, Matthias <matthias.baesken at sap.com>
>> Cc: hotspot-dev at openjdk.java.net
>> Subject: Re: RFR : 8206255 : fix
>> compiler/intrinsics/sha/cli/TestUseSHAOptionOnSupportedCPU.java jtreg
>> test on linux s390x
>>
>> Looks good Matthias (and trivial)
>>
>> ..Thomas
>>
>> On Wed, Jul 4, 2018 at 10:21 AM, Baesken, Matthias
>> <matthias.baesken at sap.com> wrote:
>>> Hello  , could you please review this small  fix  for SHA handling on  s390x.
>>> It  does  the same we have already  on  aarch64  and  x86(-64)   -   in case of
>> all 3 flags   UseSHA1Intrinsics, UseSHA256Intrinsics, UseSHA512Intrinsics   set
>> to false  we
>>>   Set also  UseSHA to false .
>>>
>>> The test
>> compiler/intrinsics/sha/cli/TestUseSHAOptionOnSupportedCPU.java
>> revealed  the difference on s390x .
>>> The test  outputs :
>>>
>>> java.lang.AssertionError: Option 'UseSHA' is expected to have 'false' value
>>> 'UseSHA' option should be disabled when all UseSHA*Intrinsics are
>> disabled
>>>
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8206255
>>>
>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8206255/
>>>
>>>
>>> Thanks, Matthias
>>>
>>>