RFR[12]: 8204834: Fix confusing "allocate" naming in OopStorage

[Kim Barrett]

> On Jul 9, 2018, at 7:37 AM, coleen.phillimore at oracle.com wrote:
> 
> 
> http://cr.openjdk.java.net/~kbarrett/8204834/open.00/src/hotspot/share/gc/shared/oopStorage.inline.hpp.udiff.html
> 
> +// Blocks in a AllocationList.
> 
> a => an

Fixed.

> Thank you for doing this renaming, Kim.  This reads a lot better for me.
> 
> Coleen

Thanks, Coleen, David, and Thomas.

> 
> 
> On 7/8/18 12:00 PM, Kim Barrett wrote:
>> Please review this nomenclature change in the implementation of
>> OopStorage.  This is a followup to JDK-8204097; in the review of that
>> change Coleen noted that some names were confusing, especially
>> "allocate_list()", which is an accessor and doesn't allocate anything!
>> 
>> This is a mostly mechanical change:
>> 
>> AllocateList => AllocationList
>> _allocate_list => _allocation_list
>> allocate_list() => allocation_list()
>> 
>> AllocateEntry => AllocationListEntry
>> _allocate_entry => _allocation_list_entry
>> allocate_entry() => allocation_list_entry()
>> 
>> _allocate_mutex => _allocation_mutex
>> 
>> There are a few non-mechanical changes in comments, to make the
>> comments consistently use the same names as the code.  For example,
>> some underscores were added when referring to members in comments.
>> Also fixed a few related typos.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8204834
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8204834/open.00/
>> 
>> Testing:
>> mach5 tier1