RFR (XS) 8207006: serviceability/sa/TestUniverse.java#id0 crashes with EpsilonGC and AOT

[Christian Thalinger]

> On Jul 11, 2018, at 12:02 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> We really need to fix GC checking when loading AOT library instead of just checking for G1. I will file a bug.

Yes, that’s the only correct way.

> 
> Based on discussion in bug report changes looks good.
> 
> Aleksey, until July 26 you can push any P1-P3 bugs you think should be fixed into JDK 11:
> http://openjdk.java.net/projects/jdk/11/
> 
> Just push into jdk/jdk11 after testing.
> 
> Thanks,
> Vladimir
> 
> On 7/11/18 6:32 AM, Aleksey Shipilev wrote:
>> (Also missed "RFR" in subject, grr)
>> -Aleksey
>> On 07/11/2018 03:31 PM, Aleksey Shipilev wrote:
>>> (This is cross-cutting compiler and GC, so posting at hotspot-dev@)
>>> 
>>> Bug:
>>>   https://bugs.openjdk.java.net/browse/JDK-8207006
>>> 
>>> All uses of ci_card_table_address() outside of CardTableBarrierSet itself check
>>> is_a(BarrierSet::CardTableBarrierSet) before reaching for card table address. Epsilon does not have
>>> a card table, so unguarded check would assert in fastdebug, and crash in release.
>>> 
>>> Trivial fix:
>>>   http://cr.openjdk.java.net/~shade/8207006/webrev.01/
>>> 
>>> I would like to push this to jdk/jdk11 but I am puzzled to how do that. Do I need to seek another
>>> approval for jdk/jdk11? Do I push to both jdk/jdk and jdk/jdk11? Or just to jdk/jdk11, and it gets
>>> forward-ported automatically?
>>> 
>>> Testing: tier1_compiler (which seems to include AOT tests), HelloWorld AOT+Epsilon, jdk-submit (running)
>>> 
>>> Thanks,
>>> -Aleksey
>>>