RFR(S) 8204267 - Generate comments in -XX:+PrintInterpreter to link to source code
Ioi Lam
ioi.lam at oracle.com
Wed Jul 11 21:03:22 UTC 2018
Thanks Andrew for the review. For the aarch64 code, maybe you can push
it as a separate bug ID, so you can do more testing first?
Thanks
- Ioi
On 7/11/18 8:44 AM, Andrew Haley wrote:
> On 07/06/2018 10:33 PM, Ioi Lam wrote:
>> Since there's interest for this patch, I've finished it for the x86 port:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8204267
>> http://cr.openjdk.java.net/~iklam/jdk12/8204267-print-interpreter-comments.v001/
> This is good. It's so good that I wish I'd havd it years ago.
> Approved.
>
> I've also tried enabling it for the stub code, and it's equally good.
> The change to the StubGenerator is very minor.
>
> My rough changes to enable AArch64 are here:
>
> http://cr.openjdk.java.net/~aph/8204267%2baarch64.patch
>
More information about the hotspot-dev
mailing list