8207006: serviceability/sa/TestUniverse.java#id0 crashes with EpsilonGC and AOT

[David Holmes]

Hi Aleksey,

On 11/07/2018 11:31 PM, Aleksey Shipilev wrote:
> (This is cross-cutting compiler and GC, so posting at hotspot-dev@)
> 
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8207006
> 
> All uses of ci_card_table_address() outside of CardTableBarrierSet itself check
> is_a(BarrierSet::CardTableBarrierSet) before reaching for card table address. Epsilon does not have
> a card table, so unguarded check would assert in fastdebug, and crash in release.
> 
> Trivial fix:
>    http://cr.openjdk.java.net/~shade/8207006/webrev.01/

Can't comment on the actual fix.

> I would like to push this to jdk/jdk11 but I am puzzled to how do that. Do I need to seek another
> approval for jdk/jdk11? Do I push to both jdk/jdk and jdk/jdk11? Or just to jdk/jdk11, and it gets
> forward-ported automatically?

As we are in RDP1 and this is a P3 issue then it can get pushed to JDK 
11 (and 12 of course). No approvals are needed for RDP1.

If you push to jdk/jdk11 it will automatically be forward-ported to 
jdk/jdk, but it may take up to a week. You can also directly 
forward-port yourself (hg import the jdk11 changeset) if you need it in 
mainline more promptly.

> Testing: tier1_compiler (which seems to include AOT tests), HelloWorld AOT+Epsilon, jdk-submit (running)

I think probably needs additional AOT testing in a later tier. But 
someone from compiler team can help with that.

David
-----

> Thanks,
> -Aleksey
>