RFR: 8202353: os::readdir should use readdir instead of readdir_r

Kim Barrett kim.barrett at oracle.com
Fri Jul 13 04:11:52 UTC 2018


> On Jul 12, 2018, at 7:48 PM, coleen.phillimore at oracle.com wrote:
> 
> 
> 
> On 7/11/18 3:06 PM, Kim Barrett wrote:
>>> On Jul 11, 2018, at 2:31 PM, coleen.phillimore at oracle.com wrote:
>>> 
>>> 
>>> This looks very nice but one question:
>>> 
>>> http://cr.openjdk.java.net/~kbarrett/8202353/open.00/src/hotspot/os/linux/os_linux.cpp.udiff.html
>>> 
>>> + while (result && (ptr = readdir(dir)) != NULL) {
>>> 
>>> 
>>> What deallocates the dirent* memory?
>> That memory belongs to the DIR* dir, and is reclaimed by the closdir(dir) at the end of the function.
>> 
> Great.  Looks good to me.
> thanks,
> Coleen

Thanks.



More information about the hotspot-dev mailing list