RFR: JDK-8208084: Windows build failure - "'snprintf': identifier not found"

[Michal Vala]

On 07/23/2018 07:15 PM, Erik Joelsson wrote:
> Hello,
> 
> On 2018-07-23 08:27, Kim Barrett wrote:
>>> On Jul 23, 2018, at 9:38 AM, Michal Vala <mvala at redhat.com> wrote:
>>>
>>> Hi,
>>>
>>> JDK-8208084 introduced build failure on Windows, where `snprintf` function is 
>>> not implemented by Visual Studio 2013 (currently latest compiler supported by 
>>> OpenJDK).
>>>
>>> I believe using `sprintf` is safe here. Please see the webrev. If it's ok, I 
>>> would also need a sponsor for this.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8208084
>>> webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8208084/webrev.00/
>>>
>>>
>>> Thanks
>>>
>>> -- 
>>> Michal Vala
>>> OpenJDK QE
>>> Red Hat Czech
>> It seems there's some documentation that needs to be updated.  JDK 11
>> supports building with VS2017, and I think with JDK 12 we'll be
>> requiring it, in preparation for starting to use features from more
>> recent C++ standards.
>>
> Indeed, that's on me. I just sent out an RFR to correct this.

Your changeset doesn't update minimal Visual Studio version. It's not buildable 
with VS2010.

-- 
Michal Vala
OpenJDK QE
Red Hat Czech