RFR 8199868: Support JNI critical functions in object pinning API

[Andrew Dinn]

Hi Zhengyu,

On 12/07/18 14:19, Zhengyu Gu wrote:
> Epsilon just became the first GC to support object pinning!
> (https://bugs.openjdk.java.net/browse/JDK-8207056)
> 
> I added test cases for Epsilon to exercise this patch.
> 
> Webrev: http://cr.openjdk.java.net/~zgu/8199868/webrev.03/index.html
> 
> Test:
> 
>   gc/epsilon on Linux 64 (fastdebug + release)
The patch itself looks fine to me. I'm not really clear what the test
case is supposed to be doing.

Zhengyu, I think you need to add an explanation of how this test will
catch errors that might arise in pinning and, in doing so, perhaps
comment on a few details of what the test does, viz: What is the point
of allocating the garbage arrays? What is the point of using
THREAD_PER_CASE * 2 threads. Why make the run methods iterate CYCLES times?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander