RFR 8199868: Support JNI critical functions in object pinning API

[Daniel D. Daugherty]

On 7/31/18 4:56 PM, Zhengyu Gu wrote:
> On 07/31/2018 04:54 PM, Daniel D. Daugherty wrote:
>> On 7/31/18 4:50 PM, Zhengyu Gu wrote:
>>> Hi Dan,
>>>
>>> On 07/31/2018 03:12 PM, Daniel D. Daugherty wrote:
>>>> This fix has broken the JDK12 CI tier1 builds:
>>>>
>>>> JDK-8208605 Fix for 8199868 breaks tier1 build
>>>> https://bugs.openjdk.java.net/browse/JDK-8208605
>>>>
>>>> Zhengyu, let me know how quickly you can have this fixed or
>>>> if you prefer I back out the fix. I'm guessing this was not
>>>> tested using jdk-submit...
>>>
>>> I did run through submit repo.
>>
>> Then the submit repo must not be doing Solaris SPARC builds...
>> Or something else... I dunno...

Apparently the jdk-submit repo does not do Solaris SPARC builds.
I do not know why not, but I'll rattle some cages on this end.

I apologize for assuming that you did not use that jdk-submit repo.

Dan


>>
>> I have a fix reviewed and I'm waiting for the mach5 tier1
>> builds to finish...
>
> Thank you, Dan.
>
> -Zhengyu
>
>>
>> Dan
>>
>>
>>
>>>
>>> http://mail.openjdk.java.net/pipermail/jdk-submit-changes/2018-July/002535.html 
>>>
>>>
>>> And results I got:
>>>
>>> Build Details: 2018-07-31-1535425.zgu.source
>>> 0 Failed Tests
>>> Mach5 Tasks Results Summary
>>>
>>>     PASSED: 75
>>>     FAILED: 0
>>>     KILLED: 0
>>>     NA: 0
>>>     UNABLE_TO_RUN: 0
>>>     EXECUTED_WITH_FAILURE: 0
>>>
>>> I will fix this right now.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>>
>>>
>>>>
>>>> Dan
>>>>
>>>>
>>>> On 7/31/18 10:37 AM, Andrew Dinn wrote:
>>>>> Hi Zhengyu,
>>>>>
>>>>> On 31/07/18 14:25, Zhengyu Gu wrote:
>>>>>> I added comments as you suggested.
>>>>>>
>>>>>> Updated webrev: http://cr.openjdk.java.net/~zgu/8199868/webrev.04/
>>>>> Ok, thanks.
>>>>>
>>>>> The above patch is reviewed modulo two misspellings of 'critical' as
>>>>> 'ciritical' in CriticalNativeStress.java.
>>>>>
>>>>> No need for another webrev.
>>>>>
>>>>> regards,
>>>>>
>>>>>
>>>>> Andrew Dinn
>>>>> -----------
>>>>> Senior Principal Software Engineer
>>>>> Red Hat UK Ltd
>>>>> Registered in England and Wales under Company Registration No. 
>>>>> 03798903
>>>>> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>>>>>
>>>>
>>