RFR (S) 8204195: Clean up macroAssembler.inline.hpp and other inline.hpp files included in .hpp files

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Jun 4 13:14:11 UTC 2018


Thanks Vladimir!
Coleen

On 6/1/18 1:02 PM, Vladimir Kozlov wrote:
> +1
>
> Thanks,
> Vladimir K
>
> On 5/31/18 4:52 PM, Jiangli Zhou wrote:
>> The changes look good to me.
>>
>> Thanks,
>> Jiangli
>>
>>> On May 31, 2018, at 4:10 PM, coleen.phillimore at oracle.com wrote:
>>>
>>> Summary: Moved macroAssembler.inline.hpp out of header file and 
>>> distributed to .cpp files that included them: ie. 
>>> c1_MacroAssembler.hpp and interp_masm.hpp. Also freeList.inline.hpp 
>>> and allocation.inline.hpp.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8204195.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8204195
>>>
>>> Tested with mach5 hs-tier1,2 on Oracle platforms: linux-x64, 
>>> solaris-sparcv9, macosx-x64 and windows-x64.  Also tested zero and 
>>> aarch64 fastdebug builds, and linux-x64 without precompiled 
>>> headers.   Please test other platforms, like arm32, ppc and s390!  I 
>>> think these are the last platform dependent inline files that are 
>>> included by .hpp files.
>>>
>>> Thanks,
>>> Coleen
>>



More information about the hotspot-dev mailing list