RFR: 8203787: Hotspot build broken on linux-sparc after 8202377

David Holmes david.holmes at oracle.com
Tue Jun 5 01:34:52 UTC 2018


On 5/06/2018 6:48 AM, Erik Österlund wrote:
> Hi Adrian,
> 
> The include you added in opto/library_call.cpp is not sorted correctly. 
> Otherwise, it looks good, and I don't need another webrev.

Also pre-existing:

   #include "memory/resourceArea.hpp"
   #include "jfr/support/jfrIntrinsics.hpp"

:)

I too don't need to see another webrev.

Thanks,
David

> Thanks,
> /Erik
> 
> On 2018-06-04 22:42, John Paul Adrian Glaubitz wrote:
>> Hi!
>>
>> Please review this minor change which partially fixes the Hotspot
>> build on linux-sparc.
>>
>> It does not fully restore the build on linux-sparc because we're still
>> suffering from JDK-8203301 Linux-sparc fails to build after JDK-8199712
>> (Flight Recorder), but I will get around fixing that in the near future
>> as well.
>>
>> The webrev can be found in [1]. I'm pushing the change to the submit-jdk
>> repository as well.
>>
>> Thanks,
>> Adrian
>>
>>> [1] http://cr.openjdk.java.net/~glaubitz/8203787/webrev.01/
> 


More information about the hotspot-dev mailing list