RFR: 8204168: Increase small heap sizes in tests to accommodate ZGC

Stefan Karlsson stefan.karlsson at oracle.com
Tue Jun 5 09:45:32 UTC 2018


Thanks for reviewing, Erik!

StefanK

On 2018-06-05 11:27, Erik Helin wrote:
> On 05/31/2018 02:32 PM, Stefan Karlsson wrote:
>> Hi all,
> 
> Hey Stefan,
> 
>> Please review this patch to increase the heap size for tests that sets 
>> a small heap size.
>>
>> http://cr.openjdk.java.net/~stefank/8204168/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-8204168
> 
> I read through each test in compiler, gc and runtime carefully to check 
> that the increased heap size wouldn't render the test useless (i.e. I 
> ensured that the tests still test something). Good news, it seems (to me 
> at least) that increasing the heap size for all of the above tests will 
> work fine. Please consider the changes to those tests Reviewed by me, 
> nice work!
> 
> Unfortunately I don't know the "nsk" tests well enough to review those 
> changes... :(
> 
> Thanks,
> Erik


More information about the hotspot-dev mailing list