8204331: AArch64: fix CAS not embedded in normal graph error.

Zhongwei Yao Zhongwei.Yao at arm.com
Tue Jun 5 15:45:32 UTC 2018


I forget to add "RFR" in the subject. So could you help have a review? Thanks.

--
Best regards,
Zhongwei

________________________________________
From: Zhongwei Yao
Sent: Tuesday, June 5, 2018 11:41:40 PM
To: hotspot-dev at openjdk.java.net
Cc: nd
Subject: RFR:  8204331: AArch64: fix CAS not embedded in normal graph error.

Hi,

Bug:
https://bugs.openjdk.java.net/browse/JDK-8204331

Webrev:
http://cr.openjdk.java.net/~zyao/8204331/webrev.00/

This patch fixes an assertion error on aarch64 in several jtreg tests.

The failure assertion is in needs_acquiring_load_exclusive() in aarch64.ad when checking whether the graph is in "leading_to_normal"  shape. The abnormal shape is generated in  LibraryCallKit::inline_unsafe_load_store(). This patch fixes it by swap the order of "Pin SCMProj node" and "Insert post barrier" in LibraryCallKit::inline_unsafe_load_store().

--
Best regards,
Zhongwei


More information about the hotspot-dev mailing list