RFR: JDK-8202776: Modularize GC allocations in runtime
Roman Kennke
rkennke at redhat.com
Tue Jun 5 17:15:32 UTC 2018
Thanks Jepser! I pushed my changes.
Cheers, Roman
> All failures in 2018-06-05-1435301.roman.source are due to JDK-8203780. You can ignore them.
> /Jesper
>
>
>> On 5 Jun 2018, at 18:31, Roman Kennke <rkennke at redhat.com> wrote:
>>
>> Submit repo came back with unstable. See below. Is it related to the
>> change? If so, can somebody with access give me a clue?
>>
>> Build Details: 2018-06-05-1435301.roman.source
>> 28 Failed Tests
>> Test Tier Platform Keywords Description Task
>> tools/javadoc/api/basic/GetTask_WriterTest.java tier1 windows-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> tools/javadoc/api/basic/GetTask_FileManagerTest.java tier1 windows-x64
>> bug6493690 bug8024434 Exception: java.lang.Exception: ... errors found
>> task
>> tools/javadoc/api/basic/GetTask_FileObjectsTest.java tier1 windows-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> jdk/javadoc/tool/api/basic/GetTask_FileManagerTest.java tier1
>> windows-x64 bug6493690 bug8024434 Exception: java.lang.Exception: ...
>> errors found task
>> jdk/javadoc/tool/api/basic/GetTask_FileObjectsTest.java tier1
>> windows-x64 bug6493690 Exception: java.lang.Exception: ... errors
>> found task
>> jdk/javadoc/tool/api/basic/GetTask_WriterTest.java tier1 windows-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> jdk/javadoc/doclet/testSearch/TestSearch.java tier1 windows-x64
>> bug8141492 bug8071982 bug8141636 bug8147890 bug8166175 bug8168965
>> bug8176794 bug8175218 bug8147881 bug8181622 bug8182263 bug8074407
>> bug8187521 bug8198522 bug8182765 bug8199278 bug8196201 bug8196202
>> Exception: FAILED: out-2\\jquery\\jquery-1.10.2.js: file not found: task
>> tools/javadoc/api/basic/GetTask_FileObjectsTest.java tier1 macosx-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> tools/javadoc/api/basic/GetTask_WriterTest.java tier1 macosx-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> tools/javadoc/api/basic/GetTask_FileManagerTest.java tier1 macosx-x64
>> bug6493690 bug8024434 Exception: java.lang.Exception: ... errors found
>> task
>> jdk/javadoc/tool/api/basic/GetTask_WriterTest.java tier1 macosx-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> jdk/javadoc/tool/api/basic/GetTask_FileManagerTest.java tier1
>> macosx-x64 bug6493690 bug8024434 Exception: java.lang.Exception: ...
>> errors found task
>> jdk/javadoc/tool/api/basic/GetTask_FileObjectsTest.java tier1
>> macosx-x64 bug6493690 Exception: java.lang.Exception: ... errors found
>> task
>> jdk/javadoc/doclet/testSearch/TestSearch.java tier1 macosx-x64
>> bug8141492 bug8071982 bug8141636 bug8147890 bug8166175 bug8168965
>> bug8176794 bug8175218 bug8147881 bug8181622 bug8182263 bug8074407
>> bug8187521 bug8198522 bug8182765 bug8199278 bug8196201 bug8196202
>> Exception: FAILED: out-1/jquery/jquery-1.10.2.js: file not found: task
>> tools/javadoc/api/basic/GetTask_FileObjectsTest.java tier1 linux-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> tools/javadoc/api/basic/GetTask_WriterTest.java tier1 linux-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> tools/javadoc/api/basic/GetTask_FileManagerTest.java tier1 linux-x64
>> bug6493690 bug8024434 Exception: java.lang.Exception: ... errors found
>> task
>> tools/javadoc/api/basic/GetTask_FileManagerTest.java tier1
>> linux-x64-open bug6493690 bug8024434 Exception: java.lang.Exception:
>> ... errors found task
>> tools/javadoc/api/basic/GetTask_FileObjectsTest.java tier1
>> linux-x64-open bug6493690 Exception: java.lang.Exception: ... errors
>> found task
>> tools/javadoc/api/basic/GetTask_WriterTest.java tier1 linux-x64-open
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> jdk/javadoc/tool/api/basic/GetTask_FileManagerTest.java tier1
>> linux-x64 bug6493690 bug8024434 Exception: java.lang.Exception: ...
>> errors found task
>> jdk/javadoc/tool/api/basic/GetTask_FileObjectsTest.java tier1
>> linux-x64 bug6493690 Exception: java.lang.Exception: ... errors found
>> task
>> jdk/javadoc/tool/api/basic/GetTask_WriterTest.java tier1 linux-x64
>> bug6493690 Exception: java.lang.Exception: ... errors found task
>> jdk/javadoc/doclet/testSearch/TestSearch.java tier1 linux-x64
>> bug8141492 bug8071982 bug8141636 bug8147890 bug8166175 bug8168965
>> bug8176794 bug8175218 bug8147881 bug8181622 bug8182263 bug8074407
>> bug8187521 bug8198522 bug8182765 bug8199278 bug8196201 bug8196202
>> Exception: FAILED: out-1/jquery/jquery-1.10.2.js: file not found: task
>> jdk/javadoc/tool/api/basic/GetTask_WriterTest.java tier1
>> linux-x64-open bug6493690 Exception: java.lang.Exception: ... errors
>> found task
>> jdk/javadoc/tool/api/basic/GetTask_FileManagerTest.java tier1
>> linux-x64-open bug6493690 bug8024434 Exception: java.lang.Exception:
>> ... errors found task
>> jdk/javadoc/tool/api/basic/GetTask_FileObjectsTest.java tier1
>> linux-x64-open bug6493690 Exception: java.lang.Exception: ... errors
>> found task
>> jdk/javadoc/doclet/testSearch/TestSearch.java tier1 linux-x64-open
>> bug8141492 bug8071982 bug8141636 bug8147890 bug8166175 bug8168965
>> bug8176794 bug8175218 bug8147881 bug8181622 bug8182263 bug8074407
>> bug8187521 bug8198522 bug8182765 bug8199278 bug8196201 bug8196202
>> Exception: FAILED: out-1/jquery/jquery-1.10.2.js: file not found: task
>> Mach5 Tasks Results Summary
>>
>> NA: 0
>> EXECUTED_WITH_FAILURE: 4
>> PASSED: 71
>> UNABLE_TO_RUN: 0
>> FAILED: 0
>> KILLED: 0
>> Test
>>
>> 4 Executed with failure
>> jdk_open_test_langtools_tier1-linux-x64-71 Results: total:
>> 3874, passed: 3867; failed: 7
>> jdk_open_test_langtools_tier1-linux-x64-open-72 Results:
>> total: 3874, passed: 3867; failed: 7
>> jdk_open_test_langtools_tier1-macosx-x64-73 Results: total:
>> 3874, passed: 3867; failed: 7
>> jdk_open_test_langtools_tier1-windows-x64-74 Results: total:
>> 3871, passed: 3864; failed: 7
>>
>>
>>> +1, looks good.
>>>
>>> -Aleksey
>>>
>>> On 06/04/2018 11:24 PM, Erik Österlund wrote:
>>>> Hi,
>>>>
>>>> Looks good.
>>>>
>>>> Thanks,
>>>> /Erik
>>>>
>>>> On 2018-06-04 23:20, Roman Kennke wrote:
>>>>> Hi Aleksey, Erik,
>>>>>
>>>>> thanks for reviewing and helping with this!
>>>>>
>>>>> Moved mem_allocate() under protected:
>>>>> Incremental:
>>>>> http://cr.openjdk.java.net/~rkennke/JDK-8202776/webrev.01.diff/
>>>>> Full:
>>>>> http://cr.openjdk.java.net/~rkennke/JDK-8202776/webrev.01/
>>>>>
>>>>> Good now?
>>>>>
>>>>> Thanks,
>>>>> Roman
>>>>>
>>>>>
>>>>>> Hi Aleksey,
>>>>>>
>>>>>> Sounds like a good idea.
>>>>>>
>>>>>> /Erik
>>>>>>
>>>>>>> On 4 Jun 2018, at 17:56, Aleksey Shipilev <shade at redhat.com> wrote:
>>>>>>>
>>>>>>> On 06/04/2018 05:29 PM, Erik Österlund wrote:
>>>>>>>>>> I agree the GC should be able to perform arbitrary allocations the way
>>>>>>>>>> it wants to.
>>>>>>>>>> However, I would prefer to do it this way:
>>>>>>>>>> http://cr.openjdk.java.net/~eosterlund/8202776/webrev.00/
>>>>>>> This looks good. I think we better hide mem_allocate under "protected" now, so we would have:
>>>>>>>
>>>>>>> protected:
>>>>>>> // TLAB path
>>>>>>> inline static HeapWord* allocate_from_tlab(Klass* klass, size_t size, TRAPS);
>>>>>>> static HeapWord* allocate_from_tlab_slow(Klass* klass, size_t size, TRAPS);
>>>>>>>
>>>>>>> // Out-of-TLAB path
>>>>>>> virtual HeapWord* mem_allocate(size_t size,
>>>>>>> bool* gc_overhead_limit_was_exceeded) = 0;
>>>>>>>
>>>>>>> public:
>>>>>>> // Entry point
>>>>>>> virtual HeapWord* obj_allocate_raw(Klass* klass, size_t size,
>>>>>>> bool* gc_overhead_limit_was_exceeded, TRAPS);
>>>>>>>
>>>>>>> -Aleksey
>>>>>>>
>>>>>
>>>>
>>>
>>>
>>
>>
>
More information about the hotspot-dev
mailing list