RFR (M) JDK-8202605: Standardize on ClassLoaderData::loader_name() throughout the VM to obtain a class loader's name

Lois Foltan lois.foltan at oracle.com
Thu Jun 14 21:28:59 UTC 2018


On 6/14/2018 5:00 PM, mandy chung wrote:

>
>
> On 6/14/18 12:56 PM, Lois Foltan wrote:
>> Please review this updated webrev that address review comments received.
>>
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8202605.1/webrev/
>
> This looks good to me.  ClassLoaderData::loader_name_and_id is better. 
> I like it.

Hi Mandy,
Thanks for the review!

>
> As to jcmd output, I agree that loader_name_and_id may not be 
> applicable here.  ClassLoaderHierarchyTest.java test added @<id> which 
> I suspect it's not intentional??
It was intentional, I did change classfile/classLoaderHierarchyDCmd.cpp 
to output the class loader's name_and_id, thus causing differing results 
for the test.  Like jcmd do you think name_and_id is not applicable here 
as well?
Lois
>
> Mandy



More information about the hotspot-dev mailing list