RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared

David Holmes david.holmes at oracle.com
Mon Jun 18 07:45:07 UTC 2018


<dropped build-dev as no build changes here>

Hi Matthias,

On 15/06/2018 5:47 PM, Baesken, Matthias wrote:
> Please review  this small  change  that fixes the AIX build after  "8203641: Refactor String Deduplication into shared"    .
> 
> We are getting this  compilation error  :
> /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", line 107.38: 1540-0063 (S) The text "1" is unexpected.
> 
> 
> Looks like the name of the second template parameter (STAT)
> 
>      template <typename QUEUE, typename STAT>
>      static void initialize_impl();
> 
> is clashing with defines from the AIX system headers  (where I find  #define STAT  1 ) .
> Renaming  STAT  to something else fixes the build on AIX .

     // STAT:  String Dedup Stat implementation
!   template <typename QUEUE, typename SI>

You need to change the comment as well. But I suggest changing to match 
the implementation:

template <typename Q, typename S>

Thanks,
David

> Webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/
> 
> Bug :
> 
> https://bugs.openjdk.java.net/browse/JDK-8205091
> 
> 
> Thanks, Matthias
> 


More information about the hotspot-dev mailing list