RFR: JDK-8205336: Modularize allocations in assembler

Roman Kennke rkennke at redhat.com
Tue Jun 19 19:46:34 UTC 2018


Am 19.06.2018 um 19:56 schrieb Andrew Haley:
> On 06/19/2018 06:14 PM, Roman Kennke wrote:
>> Can I please get reviews?
> 
> AArch64 looks OK, but it makes no sense for Register thread to be an
> argument to eden_allocate: it's rthread.  Otherwise fine.
> 
> Unless you've messed up copying some of the code, but it'd be hard
> to check all that by hand without half a day to spare...  :-(

Right. It was pre-existing (probably modeled after x86), and I wanted to
make it a 1:1 copy/refactoring job as much as possible, but yeah this is
pointless in aarch64. Let's remove it:

Incremental:
http://cr.openjdk.java.net/~rkennke/JDK-8205336/webrev.01.diff/
Full:
http://cr.openjdk.java.net/~rkennke/JDK-8205336/webrev.01/

Good now?

Thanks for reviewing!
Roman



More information about the hotspot-dev mailing list