RFR: 8205459: Rename Access API flag decorators

Kim Barrett kim.barrett at oracle.com
Thu Jun 21 16:26:39 UTC 2018


> On Jun 21, 2018, at 5:32 AM, Per Liden <per.liden at oracle.com> wrote:
> 
> Looks good, just two comments:

Thanks.

> 
> src/hotspot/share/oops/accessDecorators.hpp
> -------------------------------------------
> Looks like the decorator numbers got a bit mixed up:
> 
> […]
> Stefan just told me you planned to fix this in a different patch?

Yes.  There’s still one more change to go that affects the numbering,
the removal of IN_CONCURRENT_ROOT.  I should have mentioned
that in the RFR email though.

> src/hotspot/share/oops/access.hpp
> ---------------------------------
> Could we turn this:
> 
> 123                                              IS_ARRAY | IS_NOT_NULL |
> 124                                              IN_HEAP;
> 
> Into a single line, with IN_HEAP first, like:
> 
> 123                                              IN_HEAP | IS_ARRAY | IS_NOT_NULL;

Will do.



More information about the hotspot-dev mailing list