RFR (M) JDK-8169559: Add class loader names to relevant VM messages

[Lois Foltan]

On 6/25/2018 3:45 AM, Lindenmaier, Goetz wrote:

> Hi Lois,
>
> thanks for doing this. Also that there is joint_in_module_of_loader().
> One comment about this method:
>       class jit.t.t113.kid1 cannot be cast to class jit.t.t113.kid2 (jit.t.t113.kid1 and jit.t.t113.kid2 are in unnamed Module of loader 'app')
> This seems to be very redundant. Why not skip the class names in the module information:
>       class jit.t.t113.kid1 cannot be cast to class jit.t.t113.kid2 (both in unnamed Module of loader 'app')
> or
>       class jit.t.t113.kid1 cannot be cast to class jit.t.t113.kid2 (classes are in unnamed Module of loader 'app')
Thanks Goetz for the review!  I like your suggestion above but would 
like to include it within an RFE, I anticipate we will continue to 
improve the wording of error messages going forward.  I have created, 
https://bugs.openjdk.java.net/browse/JDK-8205611 for follow on work.

>
> I'll wait until this is pushed, and then see what is left of my change 8199940.
> We should have tests where there are custom modules and loaders printed.
I couldn't agree more, I'm hoping by including the new test 
ExpQualToM1PrivateMethodIAE.java, it might provide an example of how to 
do this for other error messages.

Thanks,
Lois

>
> Best regards,
>    Goetz.
>
>
>> -----Original Message-----
>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
>> Behalf Of Lois Foltan
>> Sent: Samstag, 23. Juni 2018 01:30
>> To: mandy chung <mandy.chung at oracle.com>
>> Cc: hotspot-dev developers <hotspot-dev at openjdk.java.net>
>> Subject: Re: RFR (M) JDK-8169559: Add class loader names to relevant VM
>> messages
>>
>> On 6/21/2018 4:37 PM, mandy chung wrote:
>>> Hi Lois,
>>>
>>> On 6/20/18 5:34 PM, Lois Foltan wrote:
>>>> Please review this change to introduce a new utility method
>>>> Klass::class_in_module_of_loader() to uniformly provide a way to add
>>>> a class' module name and class loader's name_and_id to error messages
>>>> and potentially logging.
>>>> : open webrev at
>>>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8169559/webrev/
>>> Thanks for doing this.
>>>
>>> src/hotspot/share/classfile/moduleEntry.hpp
>>>     'M' is meant to be lower case in "unnamed Module", right?
>>>
>>> src/hotspot/share/interpreter/linkResolver.cpp
>>> +      "tried to access method %s.%s%s from class %s (%s%s%s)",
>>>
>>> Since you are on this file, it may read better if rephrased to:
>>>    "class %s tried to access method %s.%s%s (%s%s%s)",
>> Hi Mandy,
>> Thanks for the review.  All your comments have been addressed, see new
>> webrev at:
>>
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8169559.1/webrev/
>>
>> Lois
>>
>>> Thanks
>>> Mandy