RFR: 8205632: Include stack.inline.hpp in markSweep.inline.hpp - Re: Build failure after "8204540: Automatic oop closure devirtualization"

[Stefan Karlsson]

Hi all,

Please review this trivial patch to fix the build issue below.

http://cr.openjdk.java.net/~stefank/8205632/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8205632

Thanks,
StefanK

On 2018-06-25 22:26, Stefan Karlsson wrote:
> On 2018-06-25 22:17, Gustavo Romero wrote:
>> Hi Stefan,
>>
>> On 06/25/2018 04:54 PM, Gustavo Romero wrote:
>>> Hi Stefan,
>>>
>>> On 06/25/2018 04:37 PM, Stefan Karlsson wrote:
>>>> This doesn't happen in our build farm, but I see that 
>>>> markSweep.inline.hpp is missing an include of stack.inline.hpp.
>>>>
>>>> Could you try with the following?:
>>>>
>>>> diff --git a/src/hotspot/share/gc/serial/markSweep.inline.hpp 
>>>> b/src/hotspot/share/gc/serial/markSweep.inline.hpp
>>>> --- a/src/hotspot/share/gc/serial/markSweep.inline.hpp
>>>> +++ b/src/hotspot/share/gc/serial/markSweep.inline.hpp
>>>> @@ -33,6 +33,7 @@
>>>>   #include "oops/access.inline.hpp"
>>>>   #include "oops/compressedOops.inline.hpp"
>>>>   #include "oops/oop.inline.hpp"
>>>> +#include "utilities/stack.inline.hpp"
>>>>
>>>>   inline void MarkSweep::mark_object(oop obj) {
>>>>     // some marks may contain information we need to preserve so we 
>>>> store them away
>>>
>>> Yes, including that header fixed the issue at my side. Thanks!
>>
>> I'm not sure how you would like to handle this: should I open a bug 
>> or are you
>> planning to include that a next change?
>>
>> Please, let me know.
>
> I can send out an RFR.
>
> Thanks,
> StefanK
>
>>
>>
>> Thanks.
>> Gustavo
>>
>