RFR(S): 8205615: Start of release updates for JDK 12 / 8205619: Bump maximum recognized class file version to 56 for JDK 12

[David Holmes]

Hi Mikael,

Generally looks good, only one issue ...

On 26/06/2018 9:44 AM, Mikael Vidstedt wrote:
> 
> All,
> 
> Shamelessly stealing the background/intro from Joe’s email to build-dev[1] earlier today:
> 
> With the JDK 11 and 12 split fast approaching [1], it is time to work on the various start of release update tasks for JDK 12. Those tasks are being tracked under the umbrella bug JDK-8205615: "Start of release updates for JDK 12".
> 
> This thread is to review the hotspot-related portions of the work including JDK-8205619: "Bump maximum recognized class file version to 56 for JDK 12”.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8205619
> CSR: https://bugs.openjdk.java.net/browse/JDK-8205642
> Webrev: http://cr.openjdk.java.net/~darcy/8205615.4/ <http://cr.openjdk.java.net/~darcy/8205615.4/>
> 
> 
> Of specific interest for hotspot are the following files:
> 
> 
> * src/hotspot/share/classfile/classFileParser.cpp
> 
> Added a JAVA_12_VERSION definition which is, for now, unused.

Good.

> 
> * src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/classfile/Classfile.java
> 
> Bumped the maximum recognized version. Doug has promised to help upstream this to Graal.

Good.

> 
> * test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> 
> Removed verification of the previously deprecated, now obsolete, VM flags.

Good.

> 
> * test/jdk/com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java
> 
> Removed the use of the previously deprecated, now obsolete, PrintSafepointStatistics flag.

Bad. Sorry you need to replace the obsolete flag with something 
non-obsolete (and preferably not deprecated) and leave the test case in 
place. I suggest the innocuous PrintVMQWaitTime.

Thanks,
David

> Testing:
> 
> The webrev as a whole has been tested using tier1-3. There are no hotspot related failures.
> 
> Cheers,
> Mikael
> 
> [1] http://mail.openjdk.java.net/pipermail/build-dev/2018-June/022528.html
> [2] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-June/001462.html <http://mail.openjdk.java.net/pipermail/jdk-dev/2018-June/001462.html>
>