8205118: CodeStrings::copy() assertion caused by -XX:+VerifyOops -XX:+PrintStubCode

[Stuart Monteith]

Hi,
   It looks good to me. Running with the following on aarch64 and
x86_64 didn't throw up any issues:
java -XX:+VerifyOops -XX:+PrintStubCode -XX:+PrintInterpreter -XX:+PrintAssembly

As well as with jtreg tier1 tests on aarch64 fastdebug build.

BR,
   StuartThanks Andrew, it checks On Fri, 22 Jun 2018 at 17:27, Andrew
Haley <aph at redhat.com> wrote:
>
> On 06/18/2018 06:07 PM, Aleksey Shipilev wrote:
> > On 06/18/2018 07:02 PM, Andrew Haley wrote:
> >> My recent patch to re-enable the printing of code comments in
> >> PrintStubCode revealed a latent bug in CodeStrings::copy().
> >> VerifyOops uses CodeStrings to hold its assertion strings, and these
> >> are distinguished from code comments by an offset of -1.  (Presumably
> >> to make sure they're not interpreted as code comments by the
> >> disassembler.)  Unfortunately, CodeStrings::copy() triggers an
> >> assertion failure when it sees any of the assertion strings.
> >>
> >> The best fix, IMO, is to correct CodeStrings::copy(): it shouldn't
> >> fail whatever the code strings are.
> >>
> >> http://cr.openjdk.java.net/~aph/8205118-1/
>
> http://cr.openjdk.java.net/~aph/8205118-2/
>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671