RFR: 8196882: VS2017 Hotspot Defined vsnprintf Function Causes C2084 Already Defined Compilation Error

[Kim Barrett]

> On Mar 1, 2018, at 12:46 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On Mar 1, 2018, at 4:16 AM, Doerr, Martin <martin.doerr at sap.com> wrote:
>> 
>> Hi Kim,
>> 
>> this change causes a build warning on 32 bit Windows with Visual Studio 2013:
>> os_windows.cpp(1521) : warning C4018: '>=' : signed/unsigned mismatch
>> 
>> I think " result >= len" should get fixed. Or is Visual Studio 2013 no longer supported?
>> Do you have a pending change in which you can update this?
>> 
>> Best regards,
>> Martin
> 
> Thanks for the report.
> 
> Oracle isn’t currently testing jdk on win32, but CRs and patches related to problems specific to it
> are still welcome.  I’m not sure why we’re not seeing this with win64; we’re still building with VS2013,
> with VS2017 support still under development and not yet our default.
> 
> I’ll file a bug and send out a fix for review shortly.

https://bugs.openjdk.java.net/browse/JDK-8198906
I pushed a fix for it last night.