RFR: 8199220: Zero build broken

Thomas Stüfe thomas.stuefe at gmail.com
Wed Mar 7 12:50:38 UTC 2018


Looks reasonable. Thank you for fixing this.

Was zero really broken for two months?

Thanks, Thomas

(Reviewer but not from Oracle, so I cannot sponsor)


On Wed, Mar 7, 2018 at 12:40 PM, Edward Nevill <edward.nevill at gmail.com>
wrote:

> Hi,
>
> Please review the following webrev which fixes broken zero build.
>
> Bugid: https://bugs.openjdk.java.net/browse/JDK-8199220
> Webrev: http://cr.openjdk.java.net/~enevill/8199220/webrev.00
>
> As this involves changes to shared hotspot code I will need a sponsor.
>
> Thanks for your help,
> Eed.
>
> -----------------------------------------------------------------
> The following symbol is reported as undefined in the Zero build
>
> ReduceInitialCardMarks
>
> This is a C2/JVMCI only symbol but is referenced unconditionally in
>
> src/hotspot/share/gc/shared/cardTableModRefBS.cpp
>
> void CardTableModRefBS::on_slowpath_allocation_exit(JavaThread* thread,
> oop new_obj) {
>    if (!ReduceInitialCardMarks) {
>      return;
>    }
>
> A second build error is
>
> /home/ed/openjdk/jdk/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:1748:
> undefined reference to `typeArrayOopDesc::byte_at_put(int, signed char)'
>
> This is caused by bytecodeInterpreter.cpp not including
> typeArrayOop.inline.hpp
>
>


More information about the hotspot-dev mailing list