RFR: 8199275: Fix inclusions of allocation.inline.hpp

Stefan Karlsson stefan.karlsson at oracle.com
Thu Mar 8 06:32:43 UTC 2018


On 2018-03-08 00:50, coleen.phillimore at oracle.com wrote:
>
> Small?

I guess I was thinking about related changes and how big they could 
become. This patch is a meager 74 lines change :)

> Well it's simple anyway.  Looks good.

Thanks.

> Please update the copyrights when you commit this.

I guess this will make this patch a medium sized patch ;)

StefanK

>
> Thanks,
> Coleen
>
> On 3/7/18 5:33 PM, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this small patch to fix some includes of 
>> allocation.inline.hpp.
>>
>> http://cr.openjdk.java.net/~stefank/8199275/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8199275
>>
>> The changes are quite simple:
>>
>> 1) SymbolHashMap::~SymbolHashMap and CDSOffsets::CDSOffsets were 
>> moved to .cpp files, since they used functions from 
>> allocation.inline.hpp.
>>
>> 2) includes of allocation.inline.hpp were added to .cpp and 
>> .inline.hpp files that used functions from allocation.inline.hpp
>>
>> The patch contains a few number added includes need after this 
>> restructuring.
>>
>> Thanks,
>> StefanK
>



More information about the hotspot-dev mailing list