RFR: 8199425: JTReg failure: runtime/stringtable/StringTableVerifyTest.java

[coleen.phillimore at oracle.com]

Hi I didn't mean that you should push.  I wanted you to do an hg commit 
and I would import the changeset and push for you.   I don't see an 
openjdk author name for you.  Have you signed the contributor agreement?

Thanks,
Coleen

On 3/9/18 11:23 PM, stewartd.qdt wrote:
> I'd love to Coleen, but having never pushed before, I'm running into issues. It seems I haven't figured out the magic set of steps yet. I get that I am unable to lock jdk/hs as it is Read Only.
>
> I'm off for the next Thursday. So, if it can wait until then, I'm happy to keep trying to figure it out. If you'd like, you may go ahead and take the webrev. It seems that is what others have done for other patches I made. But either way I'll have to figure this out.
>
> Thanks,
> Daniel
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of coleen.phillimore at oracle.com
> Sent: Friday, March 9, 2018 7:55 PM
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR: 8199425: JTReg failure: runtime/stringtable/StringTableVerifyTest.java
>
> Looks good.  Thank you for fixing this.
> Can you hg commit the patch with us as reviewers and I'll push it?
> thanks,
> Coleen
>
> On 3/9/18 5:20 PM, stewartd.qdt wrote:
>> Please review this webrev [1] which attempts to fix a test error in runtime/stringtable/StringTableVerifyTest.java. This test uses the flag -XX:+VerifyStringTableAtExit, which is a diagnostic option and requires the flag -XX:+UnlockDiagnosticVMOptions.
>>
>>
>>
>> This test currently fails our JTReg testing on an AArch64 machine. This patch simply adds the -XX:+UnlockDiagnosticVMOptions.
>>
>> The bug report is filed at [2].
>>
>>
>>
>> I am happy to modify the patch as necessary.
>>
>>
>>
>> Regards,
>>
>>
>>
>> Daniel Stewart
>>
>>
>>
>> [1] - http://cr.openjdk.java.net/~dstewart/8199425/webrev.01/
>>
>> [2] - https://bugs.openjdk.java.net/browse/JDK-8199425
>>
>>
>>