RFR (XS) 8199511: Do not generate g1_{pre|post}_barrier_slow_id without CardTable-enabled barrier set

Aleksey Shipilev shade at redhat.com
Tue Mar 13 11:05:49 UTC 2018


g1_{pre|post}_barrier_slow_id generation reaches for card table address, but it might not be
available if barrier set does not support it. Reliably asserts with Epsilon.

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8199511

Fix:
  http://cr.openjdk.java.net/~shade/8199511/webrev.01/

This is arch-specific fix:
  - c1_Runtime1_aarch64: copy-pasted the check block from g1_pre_barrier_slow_id
  - c1_Runtime1_arm:     added check block for *both* g1_{pre|post}_slow_id
  - c1_Runtime1_ppc:     already implemented
  - c1_Runtime1_s390:    already implemented
  - c1_Runtime1_sparc:   already implemented
  - c1_Runtime1_x86:     copy-pasted the check block from g1_pre_barrier_slow_id

Testing: x86_64 build, Epsilon tests, (running with submit-hs repo now)

Thanks,
-Aleksey



More information about the hotspot-dev mailing list