RFR: 8199220: Zero build broken after 8195103 and 8191102 (was RFR: 8199220: Zero build broken)

Edward Nevill edward.nevill at gmail.com
Tue Mar 13 18:30:57 UTC 2018


On Tue, 2018-03-13 at 11:24 +0100, Thomas Stüfe wrote:
> 
> 
> On Tue, Mar 13, 2018 at 11:05 AM, Edward Nevill <edward.nevill at gmail.com> wrote:
> > On Tue, 2018-03-13 at 07:10 +0100, Thomas Stüfe wrote:
> > >
> > >
> > > On Mon, Mar 12, 2018 at 10:32 PM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> > > > Reminds me of :
> > > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/029289.html
> > > >
> > > > Could this be the same issue?
> > > >
> > >
> > 
> > It is indeed exactly the same issue.
> > 
> > Was this issue ever resolved? I cannot find a JBS report or hg patch.
> > 
> > Many thanks,
> > Ed.
> > 
> 
> ... oh...
> 
>  I think Erik thought I was going to fix it, and I was counting on Erik... :-)  So, maybe it was never fixed. Adrian is the defacto maintainer of zero currently (at least he is the most active), but I think he may only build release?
> 

New webrev

http://cr.openjdk.java.net/~enevill/8199220/webrev.04

The simplest solution seemed to be to add SUPPORTS_NATIVE_CX8 to Zero as follows

+#ifdef _LP64
+#define SUPPORTS_NATIVE_CX8
+#endif

I have build fastdebug versions on x86 and aarch64 to test two different 64 bit systems.

Does it look OK now?

Thanks,
Ed.



More information about the hotspot-dev mailing list