RFR: 8199425: JTReg failure: runtime/stringtable/StringTableVerifyTest.java

Thu Mar 15 20:34:25 UTC 2018

Ah, yes, sorry about that. Here's an upate.

http://cr.openjdk.java.net/~dstewart/8199425/webrev.03/

Daniel

-----Original Message-----
From: coleen.phillimore at oracle.com [mailto:coleen.phillimore at oracle.com] 
Sent: Thursday, March 15, 2018 3:57 PM
To: stewartd.qdt <stewartd.qdt at qualcommdatacenter.com>; David Holmes <david.holmes at oracle.com>; hotspot-dev at openjdk.java.net
Subject: Re: RFR: 8199425: JTReg failure: runtime/stringtable/StringTableVerifyTest.java

Yes, it is easy but instead of -u <email> can you do commit -u dstewart (ie your openjdk username).
Then generate the webrev again and I'll sponsor it.
thanks,
Coleen

On 3/15/18 3:43 PM, stewartd.qdt wrote:
> Coleen, David,
>
> Ok ... perhaps it really is as simple as I thought it should be .... 
> <Hangs head in shame>
>
> http://cr.openjdk.java.net/~dstewart/8199425/webrev.02/
>
> I think that is what you wanted.
>
> Daniel
>
> -----Original Message-----
> From: stewartd.qdt
> Sent: Thursday, March 15, 2018 10:42 AM
> To: 'David Holmes' <david.holmes at oracle.com>; 
> coleen.phillimore at oracle.com; stewartd.qdt 
> <stewartd.qdt at qualcommdatacenter.com>; hotspot-dev at openjdk.java.net
> Subject: RE: RFR: 8199425: JTReg failure: 
> runtime/stringtable/StringTableVerifyTest.java
>
> I'm back from holiday and attempting to get this process figured out. Thanks for the help so far David and Coleen. However, after reading around openjdk.java.net and trying several things, I will have to fess up to my ignorance. I have committed my patch locally and used the "hg commit -l message" approach to get the appropriate format.
>
> However, I am at a loss for what the next step would be. So I will simply put in the actual output of hg export -g, which if I read http://openjdk.java.net/contribute/ correctly is the preferred output method.
>
> I was hoping that there would be some sort of webrev-like output that could be used to create and upload the patch. Perhaps I am to manually upload the final patch to cr.openjdk.java.net?
>
> Sorry for the most basic of issues, but I can't find a nice description of the process. (I can't even find where I got my webrev.ksh script anymore, though it was somewhere on the openjdk.java.net site).
>
> Daniel
>
> # HG changeset patch
> # User dstewart
> # Date 1521123686 0
> #      Thu Mar 15 14:21:26 2018 +0000
> # Node ID 6803b666b65dc28ea06b8622d36c15898abc7550
> # Parent  62dd99c3a6f98a943f754a6aa2ea8fcfb9cb55fd
> 8199425: JTReg failure: runtime/stringtable/StringTableVerifyTest.java
> Summary: Adding required -XX:+UnlockDiagnosticVMOptions flag to 
> StringTableVerifyTest.java
> Reviewed-by: coleenp, kvn
>
> diff --git 
> a/test/hotspot/jtreg/runtime/stringtable/StringTableVerifyTest.java 
> b/test/hotspot/jtreg/runtime/stringtable/StringTableVerifyTest.java
> --- 
> a/test/hotspot/jtreg/runtime/stringtable/StringTableVerifyTest.java
> +++ b/test/hotspot/jtreg/runtime/stringtable/StringTableVerifyTest.jav
> +++ a
> @@ -35,7 +35,7 @@
>   
>   public class StringTableVerifyTest {
>       public static void main(String[] args) throws Exception {
> -        ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-XX:+VerifyStringTableAtExit", "-version");
> +        ProcessBuilder pb =
> + ProcessTools.createJavaProcessBuilder("-XX:+UnlockDiagnosticVMOptions"
> + , "-XX:+VerifyStringTableAtExit", "-version");
>           OutputAnalyzer output = new OutputAnalyzer(pb.start());
>           output.shouldHaveExitValue(0);
>       }
>
>
>
>
> -----Original Message-----
> From: David Holmes [mailto:david.holmes at oracle.com]
> Sent: Monday, March 12, 2018 12:28 AM
> To: coleen.phillimore at oracle.com; stewartd.qdt 
> <stewartd.qdt at qualcommdatacenter.com>; hotspot-dev at openjdk.java.net
> Subject: Re: RFR: 8199425: JTReg failure: 
> runtime/stringtable/StringTableVerifyTest.java
>
> Hi Coleen, Daniel,
>
> On 11/03/2018 12:35 AM, coleen.phillimore at oracle.com wrote:
>> Hi I didn't mean that you should push.  I wanted you to do an hg 
>> commit and I would import the changeset and push for you.   I don't 
>> see an openjdk author name for you.  Have you signed the contributor agreement?
> Coleen: Daniel is dstewart (Qualcomm Datacenter Technologies is the signatory).
>
> Daniel: as Coleen indicated you can't do the hg push as you are not a 
> Committer, so just create the changeset using "hg commit" and ensure 
> the commit message has the correct format [1] e.g. from a previous 
> change of
> yours:
>
> 8196361: JTReg failure: serviceability/sa/ClhsdbInspect.java
> Summary: Modified test search strings to those guaranteed to exist in the passing cases.
> Reviewed-by: dholmes, jgeorge
>
> Thanks,
> David
>
> [1] http://openjdk.java.net/guide/producingChangeset.html#create
>
>
>
>> Thanks,
>> Coleen
>>
>> On 3/9/18 11:23 PM, stewartd.qdt wrote:
>>> I'd love to Coleen, but having never pushed before, I'm running into 
>>> issues. It seems I haven't figured out the magic set of steps yet. I 
>>> get that I am unable to lock jdk/hs as it is Read Only.
>>>
>>> I'm off for the next Thursday. So, if it can wait until then, I'm 
>>> happy to keep trying to figure it out. If you'd like, you may go 
>>> ahead and take the webrev. It seems that is what others have done 
>>> for other patches I made. But either way I'll have to figure this out.
>>>
>>> Thanks,
>>> Daniel
>>>
>>> -----Original Message-----
>>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On 
>>> Behalf Of coleen.phillimore at oracle.com
>>> Sent: Friday, March 9, 2018 7:55 PM
>>> To: hotspot-dev at openjdk.java.net
>>> Subject: Re: RFR: 8199425: JTReg failure:
>>> runtime/stringtable/StringTableVerifyTest.java
>>>
>>> Looks good.  Thank you for fixing this.
>>> Can you hg commit the patch with us as reviewers and I'll push it?
>>> thanks,
>>> Coleen
>>>
>>> On 3/9/18 5:20 PM, stewartd.qdt wrote:
>>>> Please review this webrev [1] which attempts to fix a test error in 
>>>> runtime/stringtable/StringTableVerifyTest.java. This test uses the 
>>>> flag -XX:+VerifyStringTableAtExit, which is a diagnostic option and 
>>>> requires the flag -XX:+UnlockDiagnosticVMOptions.
>>>>
>>>>
>>>>
>>>> This test currently fails our JTReg testing on an AArch64 machine.
>>>> This patch simply adds the -XX:+UnlockDiagnosticVMOptions.
>>>>
>>>> The bug report is filed at [2].
>>>>
>>>>
>>>>
>>>> I am happy to modify the patch as necessary.
>>>>
>>>>
>>>>
>>>> Regards,
>>>>
>>>>
>>>>
>>>> Daniel Stewart
>>>>
>>>>
>>>>
>>>> [1] - http://cr.openjdk.java.net/~dstewart/8199425/webrev.01/
>>>>
>>>> [2] - https://bugs.openjdk.java.net/browse/JDK-8199425
>>>>
>>>>
>>>>