[PING] Re: RFR(S): 8198794: Hotspot crash on Cassandra 3.11.1 startup with libnuma 2.0.3
David Holmes
david.holmes at oracle.com
Fri Mar 16 00:49:59 UTC 2018
Looks like I blinked first. :)
I'll sponsor this for you Gustavo.
In the future if any of your colleagues are OpenJDK committers you could
get them to sponsor you, after using submit-hs repo for testing.
Cheers,
David
On 15/03/2018 11:11 PM, Gustavo Romero wrote:
> Hi,
>
> Could somebody please sponsor the following small change?
>
> bug : https://bugs.openjdk.java.net/browse/JDK-8198794
> webrev: http://cr.openjdk.java.net/~gromero/8198794/v2/
>
> It's already reviewed by two Reviewers: dholmes and phh.
>
> Thank you!
>
>
> Regards,
> Gustavo
>
> On 03/14/2018 12:07 PM, Gustavo Romero wrote:
>> Hi David,
>>
>> On 03/13/2018 09:05 PM, David Holmes wrote:
>>>> bug : https://bugs.openjdk.java.net/browse/JDK-8198794
>>>> webrev: http://cr.openjdk.java.net/~gromero/8198794/v1/
>>>
>>> Seems okay. Couple of grammar nits with the mega comment:
>>>
>>> // it can exist nodes
>>>
>>> it -> there
>>>
>>> // are besides that non-contiguous.
>>>
>>> "are besides that" -> "may be"
>>
>> Fixed.
>>
>> webrev: http://cr.openjdk.java.net/~gromero/8198794/v2/
>>
>> Thanks a lot for reviewing it.
>>
>>
>> Could somebody sponsor that change please?
>>
>>
>> Regards,
>> Gustavo
>>
>
More information about the hotspot-dev
mailing list