RFR: 8199696: Remove Runtime1::arraycopy

[Vladimir Kozlov]

On 3/15/18 7:18 PM, David Holmes wrote:
> On 16/03/2018 3:53 AM, Vladimir Kozlov wrote:
>> Hi Erik,
>>
>> I think it is historical from time when we had Client VM with C1 only 
>> and not shared runtime.
> 
> So won't 32-bit builds still need it/use it?

Not anymore, arraycopy stubs are generated in all cases now:

http://hg.openjdk.java.net/jdk/hs/file/7a656b77a2d8/src/hotspot/cpu/x86/stubGenerator_x86_32.cpp#l3965

Vladimir

> 
> David
> 
>> Shared, x86 and Sparc changes looks good to me.
>>
>> What platforms you tested on?
>>
>> Thanks,
>> Vladimir
>>
>> On 3/15/18 8:18 AM, Erik Österlund wrote:
>>> Hi,
>>>
>>> The Runtime1::arraycopy stub appears to only be used on S390 because 
>>> there is no StubRoutines::generic_arraycopy() provided. However, C1 
>>> could then simply take a slow path and call its arraycopy stub that 
>>> performs a native call. Then this logic may be removed.
>>>
>>> I added an assert on each platform that I think should have a 
>>> generic_arraycopy() stub, and added a branch to the slow path on S390 
>>> if there is no such stub. If a stub is eventually added on S390, it 
>>> should automatically pick that up.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~eosterlund/8199696/webrev.00/
>>>
>>> Bug ID:
>>> https://bugs.openjdk.java.net/browse/JDK-8199696
>>>
>>> Thanks,
>>> /Erik