RFR: 8199696: Remove Runtime1::arraycopy

Erik Österlund erik.osterlund at oracle.com
Fri Mar 16 09:41:19 UTC 2018


Hi Vladimir,

Thank you for the review.
I tested this on all Oracle platforms with hs-tier1-3 and jdk-tier1-3, 
and Martin tested it on SAP platforms.

@Roman: Would you mind checking this on RedHat's AArch64 port?

Thanks,
/Erik


On 2018-03-15 18:53, Vladimir Kozlov wrote:
> Hi Erik,
>
> I think it is historical from time when we had Client VM with C1 only 
> and not shared runtime.
>
> Shared, x86 and Sparc changes looks good to me.
>
> What platforms you tested on?
>
> Thanks,
> Vladimir
>
> On 3/15/18 8:18 AM, Erik Österlund wrote:
>> Hi,
>>
>> The Runtime1::arraycopy stub appears to only be used on S390 because 
>> there is no StubRoutines::generic_arraycopy() provided. However, C1 
>> could then simply take a slow path and call its arraycopy stub that 
>> performs a native call. Then this logic may be removed.
>>
>> I added an assert on each platform that I think should have a 
>> generic_arraycopy() stub, and added a branch to the slow path on S390 
>> if there is no such stub. If a stub is eventually added on S390, it 
>> should automatically pick that up.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8199696/webrev.00/
>>
>> Bug ID:
>> https://bugs.openjdk.java.net/browse/JDK-8199696
>>
>> Thanks,
>> /Erik



More information about the hotspot-dev mailing list