RFR: 8199739: Use HeapAccess when loading oops from static fields in javaClasses.cpp

Stefan Karlsson stefan.karlsson at oracle.com
Fri Mar 16 15:08:28 UTC 2018


Thanks Coleen and Erik for the reviews!

StefanK

On 2018-03-16 16:04, coleen.phillimore at oracle.com wrote:
> This looks great.
> Coleen
> 
> On 3/16/18 10:39 AM, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to use HeapAccess<>::oop_load instead of 
>> oopDesc::load_decode_heap_oop when loading oops from static fields in 
>> javaClasses.cpp:
>>
>> http://cr.openjdk.java.net/~stefank/8199739/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8199739
>>
>> It's necessary to use HeapAccess<>::oop_load to inject load barriers 
>> for GCs that need them.
>>
>> Thanks,
>> StefanK
> 


More information about the hotspot-dev mailing list