RFR (L, tedious) 8199809: Don't include frame.inline.hpp and other.inline.hpp from .hpp files

[coleen.phillimore at oracle.com]

On 3/21/18 6:41 AM, Thomas Stüfe wrote:
> Hi Coleen,
>
> linuxs390 needs this:
>
> - .../source $ hg diff
> diff -r daf3abb9031f src/hotspot/cpu/s390/interpreterRT_s390.cpp
> --- a/src/hotspot/cpu/s390/interpreterRT_s390.cpp  Wed Mar 21 08:37:04 
> 2018 +0100
> +++ b/src/hotspot/cpu/s390/interpreterRT_s390.cpp  Wed Mar 21 11:12:03 
> 2018 +0100
> @@ -65,7 +65,7 @@
>  }
>
>  // Implementation of SignatureHandlerGenerator
> -InteprerterRuntime::SignatureHandlerGenerator::SignatureHandlerGenerator(
> +InterpreterRuntime::SignatureHandlerGenerator::SignatureHandlerGenerator(
>      const methodHandle& method, CodeBuffer* buffer) : 
> NativeSignatureIterator(method) {
>    _masm = new MacroAssembler(buffer);
>    _fp_arg_nr = 0;
>
> (typo). Otherwise it builds fine.

Thanks I had that typo twice, fixed.
Coleen
>
> I'm getting build errors on AIX which are a bit more complicated, 
> still looking..
>
> Thanks, Thomas
>
>
> On Wed, Mar 21, 2018 at 1:08 AM, <coleen.phillimore at oracle.com 
> <mailto:coleen.phillimore at oracle.com>> wrote:
>
>     Summary: Remove frame.inline.hpp,etc from header files and adjust
>     transitive includes.
>
>     Tested with mach5 tier1 on Oracle platforms: linux-x64,
>     solaris-sparc, windows-x64.  Built with open-only sources using
>     --disable-precompiled-headers on linux-x64, built with zero (also
>     disable precompiled headers).  Roman built with aarch64, and have
>     request to build ppc, etc.  (Please test this patch!)
>
>     Semi-interesting details:  moved SignatureHandlerGenerator
>     constructor to cpp file, moved interpreter_frame_stack_direction()
>     to target specific hpp files (even though they're all -1),
>     pd_last_frame to thread_<os_cpu>.cpp because there isn't a
>     thread_<os_cpu>.inline.hpp file, lastly moved
>     InterpreterRuntime::LastFrameAccessor into interpreterRuntime.cpp
>     file, and a few other functions moved in shared code.
>
>     This is the last of this include file technical debt cleanup that
>     I'm going to do.  See bug for more information.
>
>     open webrev at
>     http://cr.openjdk.java.net/~coleenp/8199809.01/webrev
>     <http://cr.openjdk.java.net/%7Ecoleenp/8199809.01/webrev>
>     bug link https://bugs.openjdk.java.net/browse/JDK-8199809
>     <https://bugs.openjdk.java.net/browse/JDK-8199809>
>
>     I'll update the copyrights when I commit.
>
>     Thanks,
>     Coleen
>
>