RFR (S) 8198760: Move global lock SpaceManager::_expand_lock to MutexLocker.cpp

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Fri Mar 23 16:14:02 UTC 2018



On 3/23/18 11:43 AM, Thomas Stüfe wrote:
> Hi Coleen,
>
> Looks good. Can we loose the friend declaration for SpaceManager in 
> ClassloaderMetaspace now?

No, I don't think so.  SpaceManager has another lock (the 
CLD::_metaspace_lock passed down) that ClassloaderMetaspace needs. More 
refactoring is needed!

Thanks,
Coleen

>
> Thomas
>
> On Fri 23. Mar 2018 at 12:55, <coleen.phillimore at oracle.com 
> <mailto:coleen.phillimore at oracle.com>> wrote:
>
>     Summary: We should avoid having global locks buried in cpp files
>
>     open webrev at
>     http://cr.openjdk.java.net/~coleenp/8198760.01/webrev
>     <http://cr.openjdk.java.net/%7Ecoleenp/8198760.01/webrev>
>     bug link https://bugs.openjdk.java.net/browse/JDK-8198760
>
>     Tested with mach5 tier1 and 2.
>
>     Thanks,
>     Coleen
>



More information about the hotspot-dev mailing list