RFR: 8200197: Zero fails to build after 8200105

[coleen.phillimore at oracle.com]

Looks good and trivial.
thanks,
Coleen


On 3/23/18 8:02 PM, Edward Nevill wrote:
> Hi,
>
> Please review the following webrev
>
> BugID: https://bugs.openjdk.java.net/browse/JDK-8200197
> Webrev: http://cr.openjdk.java.net/~enevill/8200197/webrev.00
>
> Zero fails to build after
>
> 8200105: Remove cyclic dependency between oop.inline.hpp and collectedHeap.inline.hpp
>
> with the error messages below
>
> The webrev above gets it building again.
>
> Thanks,
> Ed.
>
> --- CUT HERE ---
> In file included from /home/ed/openjdk/hs/src/hotspot/share/runtime/thread.hpp:29:0,
>                   from /home/ed/openjdk/hs/src/hotspot/share/utilities/events.hpp:30,
>                   from /home/ed/openjdk/hs/src/hotspot/share/gc/shared/collectedHeap.hpp:35,
>                   from /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:27:
> /home/ed/openjdk/hs/src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp:129:20: warning: inline function 'HeapWord* ThreadLocalAllocBuffer::allocate(size_t)' used but never defined
>     inline HeapWord* allocate(size_t size);
>                      ^~~~~~~~
> In file included from /home/ed/openjdk/hs/src/hotspot/share/runtime/thread.hpp:29:0,
>                   from /home/ed/openjdk/hs/src/hotspot/share/utilities/events.hpp:30,
>                   from /home/ed/openjdk/hs/src/hotspot/share/gc/shared/collectedHeap.hpp:35,
>                   from /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:27,
>                   from /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/gensrc/jvmtifiles/bytecodeInterpreterWithChecks.cpp:3:
> /home/ed/openjdk/hs/src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp:129:20: warning: inline function 'HeapWord* ThreadLocalAllocBuffer::allocate(size_t)' used but never defined
>     inline HeapWord* allocate(size_t size);
>                      ^~~~~~~~
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreter.o: In function `BytecodeInterpreter::run(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreterWithChecks.o: In function `BytecodeInterpreter::runWithChecks(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> collect2: error: ld returned 1 exit status
> lib/CompileJvm.gmk:212: recipe for target '/home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/support/modules_libs/java.base/server/libjvm.so' failed
> gmake[3]: *** [/home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/support/modules_libs/java.base/server/libjvm.so] Error 1
> gmake[3]: *** Waiting for unfinished jobs....
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreter.o: In function `BytecodeInterpreter::run(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreterWithChecks.o: In function `BytecodeInterpreter::runWithChecks(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> collect2: error: ld returned 1 exit status
> lib/CompileGtest.gmk:65: recipe for target '/home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/gtest/libjvm.so' failed
> gmake[3]: *** [/home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/gtest/libjvm.so] Error 1
> make/Main.gmk:267: recipe for target 'hotspot-zero-libs' failed
> gmake[2]: *** [hotspot-zero-libs] Error 2
>
> ERROR: Build failed for target 'jdk' in configuration 'linux-x86_64-normal-zero-release' (exit code 2)
>
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-zero_libjvm_gtest_objs_BUILD_GTEST_LIBJVM_link:
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreter.o: In function `BytecodeInterpreter::run(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreterWithChecks.o: In function `BytecodeInterpreter::runWithChecks(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> collect2: error: ld returned 1 exit status
> * For target hotspot_variant-zero_libjvm_objs_BUILD_LIBJVM_link:
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreter.o: In function `BytecodeInterpreter::run(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/objs/bytecodeInterpreterWithChecks.o: In function `BytecodeInterpreter::runWithChecks(BytecodeInterpreter*)':
> /home/ed/openjdk/hs/src/hotspot/share/interpreter/bytecodeInterpreter.cpp:2151: undefined reference to `ThreadLocalAllocBuffer::allocate(unsigned long)'
> collect2: error: ld returned 1 exit status
>
> * All command lines available in /home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/make-support/failure-logs.
> === End of repeated output ===
>
> === Make failed targets repeated here ===
> lib/CompileJvm.gmk:212: recipe for target '/home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/support/modules_libs/java.base/server/libjvm.so' failed
> lib/CompileGtest.gmk:65: recipe for target '/home/ed/openjdk/hs/build/linux-x86_64-normal-zero-release/hotspot/variant-zero/libjvm/gtest/libjvm.so' failed
> make/Main.gmk:267: recipe for target 'hotspot-zero-libs' failed
> === End of repeated output ===
>
> Hint: Try searching the build log for the name of the first failed target.
> Hint: See doc/building.html#troubleshooting for assistance.
>
> /home/ed/openjdk/hs/make/Init.gmk:291: recipe for target 'main' failed
> make[1]: *** [main] Error 2
> /home/ed/openjdk/hs/make/Init.gmk:186: recipe for target 'jdk' failed
> make: *** [jdk] Error 2
> --- CUT HERE ---
>